Preserve query parameters in form options sources - #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
?search=..., which dropped or corrupted any existing query parameters inoptions_sourceURLs.options_sourcealready contained parameters (for example...?id=...or?category=...) and required a robust way to add/replace thesearchparameter.Description
sqlpage/tomselect.jsreplaced string concatenation with the browserURLAPI andURLSearchParamsto build the request URL:new URL(options_source, document.baseURI)andoptions_url.searchParams.set("search", query)before callingfetch.tests/end-to-end/official-site.spec.tsto exercise and assert that existing query parameters are preserved when remote searches run.options_sourcewith an existing query parameter inexamples/official-site/sqlpage/migrations/01_documentation.sql.CHANGELOG.mdentry describing the fix.Testing
npm run formatwhich completed successfully.npm test(the repositorybiome checkstep) which completed successfully but reported lint diagnostics/warnings (no test failures).git diff --checkwhich reported no issues after the changes.Codex Task