Open
Conversation
Member
|
I'll have to make it a branch since otherwise lots of tests will fail. On the bright side, getting rid of this means the fork is very minimal and easy to rebase on top of ILSpy trunk. |
Member
Author
|
Really no test should fail until we repoint JSIL to that commit. :) But I'm fully OK with branch - I only need have this commit in your repo :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've starting work on moving dynamic interaction to JavaScript side in JSIL translated sources.
With it we will not need anymore special processing of them in ILSpy.
I've backouted your commit that implement such processing,
Could you merge it (probably to separate branch) to simplify me cross-repo pull requests?