feat: replace binance tss for signing with rust cggmp21 crate#192
Draft
mpetrunic wants to merge 2 commits into
Draft
feat: replace binance tss for signing with rust cggmp21 crate#192mpetrunic wants to merge 2 commits into
mpetrunic wants to merge 2 commits into
Conversation
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap of binance tss library with rust crate for cggmp21 signing using cgo. Unfortunately, rust library doesn't support key resharing so I left existing keygen and resharing using binance tss lib. Big problem is that keyshare format and data, so claude wrote some converter function.
It seems like tests are passing. That said, I don't think current ai slop is ready to be merged, it would probably have to be reviewed and rewritten piece by piece
Description
Related Issue Or Context
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: