fix(saaj): sync header changes before getDocument() - #1849
Open
arimu1 wants to merge 1 commit into
Open
Conversation
Call saveChanges() in SaajSoapMessage.getDocument() before serializing the SAAJ message so header elements added via SoapHeader.addHeaderElement are reflected in the returned Document. Fixes spring-projects#1153 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveChanges()inSaajSoapMessage.getDocument()before serializing the backing SAAJ messageSoapHeader.addHeaderElement()are reflected in the returnedDocument(fixes MockWebServiceServer /SoapEnvelopeDiffMatchermismatches)Fixes #1153
Root cause
getDocument()serializes the SAAJ message viawriteTo()without first callingsaveChanges(). In-memory header mutations fromaddHeaderElement()are therefore omitted from the serialized DOM even though they appear when the message is sent viawriteTo()(which already callssaveChanges()).Test plan
./gradlew :spring-ws-core:test --tests "org.springframework.ws.soap.saaj.SaajSoap11MessageTests.getDocumentReflectsAddedHeaderElement"./gradlew :spring-ws-core:test --tests "org.springframework.ws.soap.saaj.SaajSoap12MessageTests.getDocumentReflectsAddedHeaderElement"./gradlew :spring-ws-core:test --tests "org.springframework.ws.soap.saaj.*"Signed-off-by: arimu1 19286898+arimu1@users.noreply.github.com
Made with Cursor