Skip to content

Prompt to enable JSpecify null analysis - #1954

Open
ziplla wants to merge 1 commit into
spring-projects:mainfrom
ziplla:fix/gh-1715-jspecify-ask-user-to-enable--3
Open

Prompt to enable JSpecify null analysis#1954
ziplla wants to merge 1 commit into
spring-projects:mainfrom
ziplla:fix/gh-1715-jspecify-ask-user-to-enable--3

Conversation

@ziplla

@ziplla ziplla commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Fixes #1715

This change implements the focused fix and regression coverage described in the issue.

Validation: the repository pull-request workflow passed: https://github.com/ziplla/spring-tools/actions/runs/30659169388

@BoykoAlex BoykoAlex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my doubts about this.

  1. This is probably for JDT UI not for spring tools
  2. I'd try to look for an alternative to ui.startup extension to activate this. Likely moving this to JDT UI would resolve my concern implicitly

@ziplla

ziplla commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

The prompt is JDT-wide rather than Spring-specific, and removing the startup extension meaningfully depends on where the feature should live. Please confirm whether this PR should be closed in favor of an upstream JDT UI contribution or retained here using a Spring Tools activation hook.

@martinlippert

Copy link
Copy Markdown
Member

I think we should at least see if the folks working on JDT UI would be interested in this. I think I haven't seen this kind of feature/compiler activation prompts in JDT UI yet, so this might raise questions and discussions how this kind of feature should be implemented, but that is probably a good thing which could drive consistency in Eclipse.

@ziplla Would you go ahead and raise that question / PR with JDT UI and link to it from here?

Fixes spring-projectsgh-1715

Signed-off-by: Pavel Zaitsev <pzajtsev@yandex.ru>
@ziplla
ziplla force-pushed the fix/gh-1715-jspecify-ask-user-to-enable--3 branch from 085f84a to b67c248 Compare August 3, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[jspecify] ask user to enable null analysis after project import

3 participants