GH-1778 - Clarify violation for non-exposed types in allowed modules - #1785
Open
kalayciburak wants to merge 1 commit into
Open
Conversation
…llowed modules. When a dependency targets a module that is allowed (for example via sharedModules) but the concrete type is not part of an allowed named interface, report the non-exposed-type message instead of the ambiguous "Allowed targets: <module>" wording. Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1778.
When a module is allowed as a dependency target (for example because it is listed in
@Modulithic(sharedModules = …)) but the concrete type is not part of an allowed named interface, verification previously reported:That message is ambiguous: the module appears in the allowed targets list while the dependency is still rejected. The intended diagnosis is that the type is not exposed.
Change
In
QualifiedDependency.isValidDependencyWithin, if the target module is present in the origin module's allowed dependencies but the target type is not exposed, emit the existing non-exposed-type violation (INTERNAL_REFERENCE) instead of the generic "Allowed targets" message.Tests
reproducers.gh1778.Gh1778Tests(sharedreviewmodule + internalreview.analysis.AnalyzerService)./mvnw -pl spring-modulith-core test— 94/94 GREEN./mvnw -pl spring-modulith-integration-test -am test -Dtest=ApplicationModulesIntegrationTest— 19/19 GREEN