GH-1774 | Modernize auto-configuration registration. - #1782
Open
ch200203 wants to merge 1 commit into
Open
Conversation
Remove the EnableAutoConfiguration entries from spring.factories files that are no longer read since Spring Boot 3.0, as the classes are already registered via AutoConfiguration.imports. Switch the affected auto-configuration classes from @configuration(proxyBeanMethods = false) to @autoConfiguration, folding the standalone @AutoConfigureBefore on JdbcEventPublicationAutoConfiguration into the annotation's before attribute. Signed-off-by: Cheolhwan Ihn <ch200203@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1774.
EnableAutoConfigurationentries fromspring.factoriesinspring-modulith-moments(file deleted) andspring-modulith-events-jpa. TheEventPublicationConfigurationExtensionentry in the latter is kept, as it is still consumed by theEnablePersistentDomainEventsimport selector.MomentsAutoConfiguration,ModuleObservabilityAutoConfiguration,SpringDataRestModuleObservabilityAutoConfiguration, andJdbcEventPublicationAutoConfigurationfrom@Configuration(proxyBeanMethods = false)to@AutoConfiguration, folding the standalone@AutoConfigureBeforeon the JDBC one into the annotation'sbeforeattribute.No runtime behavior change intended — all four classes were already registered via
AutoConfiguration.imports.