Skip to content

Ensure parsing/toString symmetry in ContentDisposition name #37133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashsiwacha wants to merge 1 commit into from
+13 −2
Closed

Ensure parsing/toString symmetry in ContentDisposition name #37133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spring-web/src/main/java/org/springframework/http/ContentDisposition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public String toString() {
sb.append(this.type);
}
if (this.name != null) {
sb.append("; name=\"").append(this.name).append('\"');
sb.append("; name=\"").append(encodeQuotedPairs(this.name)).append('\"');
}
if (this.filename != null) {
if (this.charset == null || StandardCharsets.US_ASCII.equals(this.charset)) {
Expand Down Expand Up @@ -253,7 +253,7 @@ public static ContentDisposition parse(String contentDisposition) {
part.substring(eqIndex + 2, part.length() - 1) :
part.substring(eqIndex + 1));
if (attribute.equals("name") ) {
name = value;
name = (value.indexOf('\\') != -1 ? decodeQuotedPairs(value) : value);
}
else if (attribute.equals("filename*") ) {
int idx1 = value.indexOf('\'');
Expand Down
11 changes: 11 additions & 0 deletions spring-web/src/test/java/org/springframework/http/ContentDispositionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,17 @@ void formatWithEncodedFilenameUsingInvalidCharset() {
.build()
.toString());
}

@Test
void formatAndParseWithNameWithQuotes() {
ContentDisposition cd = ContentDisposition.formData()
.name("foo\"bar\\baz")
.build();
assertThat(cd.toString()).isEqualTo("form-data; name=\"foo\\\"bar\\\\baz\"");

ContentDisposition parsed = ContentDisposition.parse("form-data; name=\"foo\\\"bar\\\\baz\"");
assertThat(parsed.getName()).isEqualTo("foo\"bar\\baz");
}
}

}