Avoid redundant registration of legacy date converters#36953
Open
arnabnandy7 wants to merge 1 commit into
Open
Avoid redundant registration of legacy date converters#36953arnabnandy7 wants to merge 1 commit into
arnabnandy7 wants to merge 1 commit into
Conversation
Prior to this commit, DateTimeFormatterRegistrar registered legacy date converters via DateTimeConverters.registerConverters, which in turn called DateFormatterRegistrar.addDateConverters. Since DefaultFormattingConversionService registers both DateTimeFormatterRegistrar and DateFormatterRegistrar, this resulted in redundant double registration of legacy converters (such as DateToLongConverter, CalendarToDateConverter, etc.). This commit removes the redundant call to addDateConverters from DateTimeConverters.registerConverters, ensuring legacy date converters are only registered by DateFormatterRegistrar. Closes spring-projectsgh-36951 Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, DateTimeFormatterRegistrar registered legacy date converters via DateTimeConverters.registerConverters, which in turn called DateFormatterRegistrar.addDateConverters.
Since DefaultFormattingConversionService registers both DateTimeFormatterRegistrar and DateFormatterRegistrar, this resulted in redundant double registration of legacy converters (such as DateToLongConverter, CalendarToDateConverter, etc.).
This commit removes the redundant call to addDateConverters from DateTimeConverters.registerConverters, ensuring legacy date converters are only registered by DateFormatterRegistrar.
Closes gh-36951