Skip to content

Include cross-parameter violations in hasErrors() and getAllErrors() #36672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tianhaocui wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

Include cross-parameter violations in hasErrors() and getAllErrors() #36672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...g-context/src/main/java/org/springframework/validation/method/MethodValidationResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.lang.reflect.Method;
import java.util.Collections;
import java.util.List;
import java.util.stream.Stream;

import org.springframework.context.MessageSourceResolvable;
import org.springframework.validation.Errors;
Expand Down Expand Up @@ -56,17 +57,22 @@ public interface MethodValidationResult {
* Whether the result contains any validation errors.
*/
default boolean hasErrors() {
return !getParameterValidationResults().isEmpty();
return !getParameterValidationResults().isEmpty() ||
!getCrossParameterValidationResults().isEmpty();
}

/**
* Return a single list with all errors from all validation results.
* Return a single list with all errors from all validation results,
* including cross-parameter validation errors.
* @see #getParameterValidationResults()
* @see #getCrossParameterValidationResults()
* @see ParameterValidationResult#getResolvableErrors()
*/
default List<? extends MessageSourceResolvable> getAllErrors() {
return getParameterValidationResults().stream()
.flatMap(result -> result.getResolvableErrors().stream())
return Stream.concat(
getParameterValidationResults().stream()
.flatMap(result -> result.getResolvableErrors().stream()),
getCrossParameterValidationResults().stream())
.toList();
}

Expand Down