Embedded LDAP SSL should not be enabled when its bundle is empty#50700
Open
leestana01 wants to merge 1 commit into
Open
Embedded LDAP SSL should not be enabled when its bundle is empty#50700leestana01 wants to merge 1 commit into
leestana01 wants to merge 1 commit into
Conversation
EmbeddedLdapProperties.Ssl.isEnabled() derived enablement from this.bundle != null, so it returned true even when the bundle was overridden to an empty string. Use StringUtils.hasText(this.bundle) to align with the other SSL properties classes (Cassandra, Couchbase, MongoDB, Redis, RabbitMQ) and the documented "enabled automatically if 'bundle' is provided" behavior. Signed-off-by: leestana01 <leestana01@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedLdapProperties.Ssl.isEnabled()derives enablement fromthis.bundle != null, so it returnstrueeven when the bundle is overridden to an empty string.This was harmonized for the other SSL properties classes in #50624 (Cassandra, MongoDB, Redis, Mail), and Couchbase/RabbitMQ already used
StringUtils.hasText(...), butEmbeddedLdapPropertieswas missed. This aligns it with those classes and with its own Javadoc ("Enabled automatically if 'bundle' is provided").Note:
EmbeddedLdapAutoConfigurationadditionally guards the bundle withStringUtils.hasLength(...), so this corrects the property's contract rather than changing the end-to-end auto-configuration behaviour.