Fix Javadoc for GraylogExtendedLogFormatProperties#50699
Open
leestana01 wants to merge 1 commit into
Open
Conversation
The class-level description ("Service details for...") and the `service`
component description ("the version of the application") were copied from
the nested Service record and not adapted. Correct them to match the
parallel ElasticCommonSchemaProperties: the type holds properties and the
`service` component holds service details.
Signed-off-by: leestana01 <leestana01@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class-level Javadoc and the
servicecomponent description ofGraylogExtendedLogFormatPropertieswere copied from the nestedServicerecord and not adapted:@param serviceis described as "the version of the application", which is the description ofService.version, not theservicecomponent (aService).Align both with the parallel
ElasticCommonSchemaProperties("Properties for … structured logging." /@param service service details).Javadoc only — no behavior change.