Fix #1324: Add @JsonAlias support to SimplePageable for SNAKE_CASE co…

[weslyvinicius]

Fixes #1324

When a global PropertyNamingStrategies.SNAKE_CASE is configured, deserialization of Page<T> fails because SimplePageable only accepted camelCase property names.

This PR adds @JsonProperty + @JsonAlias to the constructor parameters, supporting:

• pageNumber / page_number / page-number / pagenumber
• pageSize / page_size / page-size / pagesize

Tested with the reproduction case provided in the issue (global SNAKE_CASE + WireMock returning snake_case JSON).

[spencergibb]

Please add a test that verifies the fix.

[weslyvinicius]

Thanks for the review! I've added tests to verify the fix.

The tests follow the same pattern as the existing ones in PageJacksonModuleTests:

Test methods added:

• deserializePageableWithHyphenatedAlias() - validates page-number and page-size
• deserializePageableWithUnderscoreAlias() - validates page_number and page_size
• deserializePageableWithLowercaseAlias() - validates pagenumber and pagesize
• deserializePageableWithPascalCaseAlias() - validates PageNumber and PageSize

Test resource files added (in src/test/resources/):

• withPageableAliasHyphen.json
• withPageableAliasUnderscore.json
• withPageableAliasLowercase.json
• withPageableAliasPascalCase.json

All tests pass and verify that the @JsonAlias annotations correctly handle different naming conventions for pageNumber and pageSize fields in the pageable object.

[ryanjbaxter]

Please sign your commits so the DCO passes

[ryanjbaxter]

Is this also a problem in the 4.3.x branch? If so please make the PR against that branch

[weslyvinicius]

Please sign your commits so the DCO passes

Hi @ryanjbaxter,

Thanks for the heads-up!

I've fixed the DCO issue. I added the Signed-off-by line to the two commits that were missing it:

• de61fd55 Fix Add @JsonAlias support to SimplePageable in PageJacksonModule for snake_case compatibility with global SNAKE_CASE naming strategy #1324: Add @JsonAlias support to SimplePageable for SNAKE_CASE compatibility
• 15c9f5bd Add tests for pageable deserialization with various alias formats

[ryanjbaxter]

See #1325 (comment)

[weslyvinicius]

Is this also a problem in the 4.3.x branch? If so please make the PR against that branch

Yes, the issue is also present in the 4.3.x branch.
I have created a separate PR targeting 4.3.x:

[spencergibb]

Closing in favor of #1329. We will merge forward to main.