Allow query parameters without value in proxied URL.#4228
Open
zamzterz wants to merge 1 commit into
Open
Conversation
Align the behavior of query parameters in MvcUtils with HierarchicalUriComponents from spring-web to allow query parameters without value to be passed along in the proxied request by ProxyExchangeHandlerFunction. This allows custom filter implementations to transform incoming query parameters to be preserved without trailing equal sign such that '?param' in the original request is not proxied as ´?param='. Fixes spring-cloudgh-3197. Signed-off-by: Samuel Gulliksson <samuel.gulliksson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the behavior of query parameters in MvcUtils with HierarchicalUriComponents from spring-web to
allow query parameters without value to be passed along in the proxied request by ProxyExchangeHandlerFunction.
A query parameter
?paramin the incoming request is still parsed as"param" -> [""]by webmvc, but this change allows custom filter implementations (like the one in the included testgatewayRouterFunctionsEmptyQueryParamFilter) to transform incoming query parameters to be preserved without trailing equal sign such that?paramin the original request is not proxied as?param=.Fixes gh-3197.