Fix RFC 7239 Forwarded header relay for entries without for#4218
Open
softho0n wants to merge 1 commit into
Open
Fix RFC 7239 Forwarded header relay for entries without for#4218softho0n wants to merge 1 commit into
softho0n wants to merge 1 commit into
Conversation
Preserve existing Forwarded header entries that do not contain a `for` parameter in both WebFlux and MVC filters. Fixes spring-cloudgh-4214 Signed-off-by: seunghun shin <18shshin@gmail.com>
softho0n
force-pushed
the
gh-4214-forwarded-header-optional-for
branch
from
e07c57a to
8f53a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 7239, all forwarded-pair entries are optional. Both
ForwardedHeadersFilter(webflux) andForwardedRequestHeadersFilter(webmvc)currently drop entries where
foris absent, even when sent by trusted proxies(remote address is already validated earlier in the same method).
This causes legitimate upstream
host/protoinformation to be silently lostin multi-hop proxy chains. The webmvc filter also throws NPE on null
for.Changes:
for == null OR trustedProxies.isTrusted(forValue)TrustedProxies.isTrustedFixes gh-4214