Skip to content

🐛 fix(cmd): align process exit APIs with host runtime#20

Merged
zrr1999 merged 1 commit into
mainfrom
fix/process-exit-runtime-consistency
May 16, 2026
Merged

🐛 fix(cmd): align process exit APIs with host runtime#20
zrr1999 merged 1 commit into
mainfrom
fix/process-exit-runtime-consistency

Conversation

@zrr1999
Copy link
Copy Markdown
Member

@zrr1999 zrr1999 commented May 6, 2026

Summary

  • return process exit status as Option[U8] so signaled processes map to None
  • narrow exit to U8 and cover the runtime behavior with host tests
  • update README notes to reflect the generic package-backed host path and remaining follow-up gaps

Validation

  • cargo fmt --manifest-path host/Cargo.toml --check
  • cargo clippy --manifest-path host/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path host/Cargo.toml
  • spore format --check
  • spore check src/basic_cli/cmd.sp
  • spore build src/basic_cli/cmd.sp

Notes

  • Aligns basic_cli.cmd with SEP-0003/SEP-0009 guidance that process exit conversion is a Platform/runtime concern while the surface requires the Exit effect.

@zrr1999 zrr1999 force-pushed the fix/process-exit-runtime-consistency branch from e25245e to 0c7970f Compare May 6, 2026 02:28
…on[U8]

- Changed `process_run_status` to return `Option[U8]` instead of `I32`, allowing for better handling of exit codes.
- Updated `exit` function to accept `U8` instead of `I32` for consistency with the new exit code handling.
- Adjusted related documentation in README to reflect changes in runtime support for `basic-cli` applications.
@zrr1999 zrr1999 force-pushed the fix/process-exit-runtime-consistency branch from 0c7970f to db34496 Compare May 16, 2026 14:04
@zrr1999 zrr1999 changed the title Align basic-cli process exit APIs with host runtime 🐛 fix(cmd): align process exit APIs with host runtime May 16, 2026
@zrr1999 zrr1999 merged commit b12f035 into main May 16, 2026
5 of 12 checks passed
@zrr1999 zrr1999 deleted the fix/process-exit-runtime-consistency branch May 16, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant