-
Notifications
You must be signed in to change notification settings - Fork 0
♻️ refactor: align basic-cli with effect terminology #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c27b451
📝 docs: update README and spore.toml to reflect effect tracking changes
zrr1999 abdbb39
🔧 ci: streamline CI workflow for Spore CLI commands
zrr1999 7996f63
🔧 ci: update CI workflow for Spore CLI installation
zrr1999 e5f7631
🔧 ci: update actionlint integration in CI workflow
zrr1999 b8afc2e
🔧 ci: update Spore CLI version in CI workflow
zrr1999 9e6149c
🐛 fix: align basic-cli CI with current compiler
Copilot 7236821
📝 docs: record spore CI project-mode gotcha
Copilot 24cefef
ci: install Rust 1.95 before spore CLI install
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Project Learnings | ||
|
|
||
| ## Gotchas | ||
| - [Spore CI should target project-mode files explicitly](gotchas/spore-ci-project-mode.md) — spore, ci, project-mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| --- | ||
| title: "Spore CI should target project-mode files explicitly" | ||
| category: gotchas | ||
| tags: [spore, ci, project-mode, basic-cli] | ||
| created: 2026-04-28 | ||
| context: "basic-cli CI needed to validate a package-backed example with the shipped compiler" | ||
| --- | ||
|
|
||
| ## Problem | ||
|
|
||
| The current `spore` CLI validates package-backed examples reliably when given the explicit entry file, but bare directory invocations and standalone file assumptions can fail depending on current compiler surface and imports. | ||
|
|
||
| ## Solution | ||
|
|
||
| Use explicit file targets for project-mode checks: | ||
|
|
||
| ```bash | ||
| spore check examples/hello-app/src/main.sp | ||
| spore build examples/hello-app/src/main.sp | ||
| cd examples/hello-app && spore run src/main.sp | ||
| ``` | ||
|
|
||
| ## Key points | ||
|
|
||
| - Keep CI focused on the canonical package-backed entry file. | ||
| - Treat standalone `.sp` examples as separate from project-mode validation. | ||
| - Re-run `spore format --check`, `spore check`, and `spore build` against explicit files when compiler behavior is in flux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| /// Canonical package-backed application example for basic-cli. | ||
| /// | ||
| /// This mirrors the formatted `spore new` scaffold: import the | ||
| /// platform module explicitly and call `println` directly from the | ||
| /// imported basic-cli surface. | ||
| /// Application entry point matching the platform contract. | ||
| // Canonical package-backed application example for basic-cli. | ||
| // | ||
| // This mirrors the formatted `spore new` scaffold: import the | ||
| // platform module explicitly and call `println` from the imported | ||
| // basic-cli surface. | ||
| import basic_cli.stdout as stdout | ||
|
|
||
| /// Application entry point matching the platform contract. | ||
| fn main() -> () uses [Console] { | ||
| println("Hello from a project-mode Spore application!") | ||
| println("Hello from a project-mode Spore application!"); | ||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.