[Draft] CSPL-4186: Support splunk secret and make it available to Ansible via mount#1747
Draft
[Draft] CSPL-4186: Support splunk secret and make it available to Ansible via mount#1747
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22699314688Details
💛 - Coveralls |
vivekr-splunk
requested changes
Mar 4, 2026
| switch *imagePullPolicy { | ||
| case "": | ||
| *imagePullPolicy = "IfNotPresent" | ||
| *imagePullPolicy = "Never" |
Author
There was a problem hiding this comment.
It's a mistake. I was trying to test with the docker splunk which was pushed to internal registry so I made this temporary change. I have reverted all changes in this file.
| secret: "%s" | ||
| shc: | ||
| secret: "%s" | ||
| `, |
Collaborator
There was a problem hiding this comment.
We need to find a way to validate the fields within the secret to ensure they are valid. There is no built-in way to do this in Docker. If the configuration is incorrect and something fails, Docker does not return clear errors, which makes it difficult for the operator to interpret the issue. It would be better to add validation on both sides to catch these problems earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support splunk.secret and make it available to Ansible via mount.
Key Changes
Testing and Verification
Tested the change with the latest Ansible which reads the splunk_secret from mount and copied it to /etc/auth.
Related Issues
CSPL-4186.
PR Checklist