Skip to content

Fix/HYBIM-962 review follow ups - #209

Open
pradystar wants to merge 2 commits into
mainfrom
fix/HYBIM-962-review-follow-ups
Open

Fix/HYBIM-962 review follow ups#209
pradystar wants to merge 2 commits into
mainfrom
fix/HYBIM-962-review-follow-ups

Conversation

@pradystar

@pradystar pradystar commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Harden OTLP content mapping, acknowledgement diagnostics, and operation trace ownership for several edge cases found during review.

Follow ups from reviews

  1. https://github.com/splunk/splunk-ao-python/pull/191#pullrequestreview-4824427206 check the minor(bug) in this review.
  2. fix(otel): surface successful-response span rejections #188 (review) check the follow up in this review.
  3. Fix/SAO-259 operation trace ownership #187 (review) follow up and minor review

What changed

  • Preserve explicitly empty message parts lists instead of serializing them as the text "[]".
  • Recognize finite, positive integral JSON-number rejection counts such as 3.0 in OTLP partial-success acknowledgements.
  • Centralize current-root ownership checks shared by decorators, synchronous/asynchronous handlers, and OpenAI Agents failure cleanup.
  • Add regression coverage for invalid rejection counts and async decorated-operation exception cleanup.
  • Document the user-visible fixes in the changelog.

Testing

  • poetry run pytest — 2,157 passed, 4 skipped.
  • Focused converter, exporter, decorator, handler, and OpenAI Agents suites — 446 passed, 1 skipped.
  • inv type-check — passed for 116 source files.
  • Changed-file pre-commit hooks, poetry check --lock, and git diff --check passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant