Skip to content

Split and tweak of linux_docker_privilege_escalation#3929

Open
DipsyTipsy wants to merge 5 commits intosplunk:developfrom
DipsyTipsy:linux_docker_detection_split
Open

Split and tweak of linux_docker_privilege_escalation#3929
DipsyTipsy wants to merge 5 commits intosplunk:developfrom
DipsyTipsy:linux_docker_detection_split

Conversation

@DipsyTipsy
Copy link
Contributor

Details

Current logic in linux_docker_privilege_escalation hits on a lot of undesired activity because of the generous wildcards. The query in it self also tries to perform a bit to many things in one single query. Suggesting splitting the detection into two:

  • linux_docker_root_directory_mount (Suggesting moving to TTP)
  • linux_docker_shell_execution

Tweaked the queries to hit more precisely, as well as updating the mitre annotations.
Not entirely sure how you want the retirement of detection's to be performed, so leaving this out. Also a bit unsure on how the versioning and author values should be handled in these cases.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

…fying the queries to more precisely trigger on the activity
Copy link
Contributor

@nasbench nasbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just general comments before review based on your question.

  • The new detections will have new UUIDs/Version.
  • The old detection should be moved to the deprecated folder in the detections folder.
  • We need to update the deprecation mapping yaml
  • As for the author, if the search is was not changed just a split. Use only the original author. If you did some changes to the logic then add yourself.

I will give this a review later on. Thanks for taking the time on this,

Do not worry on the deprecation stuff. We will do it on your behalf.

@nasbench nasbench added this to the v5.24.0 milestone Mar 2, 2026
Copy link
Contributor

@nasbench nasbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I deprecated the other detections and tweaked formatting as well as the list of shells.

Since you can execute the shell as the last param to start a new shell session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants