add throughput summary and fix timmer blocked by end=3 count=0 settings#346
Open
Yangxulight wants to merge 5 commits intodevelopfrom
Open
add throughput summary and fix timmer blocked by end=3 count=0 settings#346Yangxulight wants to merge 5 commits intodevelopfrom
Yangxulight wants to merge 5 commits intodevelopfrom
Conversation
Contributor
|
Would you add a functional test for throughput summary? |
Contributor
+1. Especially for the end = 3 and count = 0 setting scenario. Thanks, Ryan. |
Contributor
Author
|
It seems that the CircleCI was blocked by my test code(ec9192c). Do you guys have some ideas about the reason? |
Contributor
Could you place the test logic in another test function since you need to set the conf and start eventgen and validate the logic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is what I did in this PR: