fix Warning: Array to string conversion in metadata.php#216
Open
mprins wants to merge 3 commits intosplitbrain:masterfrom
Open
fix Warning: Array to string conversion in metadata.php#216mprins wants to merge 3 commits intosplitbrain:masterfrom
mprins wants to merge 3 commits intosplitbrain:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix issue #198, which reports "Array to string conversion" warnings in metadata.php when loading pages with galleries. The fix modifies how image data is passed to DokuWiki's renderer methods by using the spread operator to unpack array values.
Key Changes:
- Modified
externallink()call to unpack$imgdataarray values using spread operator - Modified
internalmedia()call to unpack$imgdataarray values using spread operator
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #198
fixes #210