Skip to content

Update Go templates#3492

Open
fibonacci1729 wants to merge 6 commits intomainfrom
update-go-tpls
Open

Update Go templates#3492
fibonacci1729 wants to merge 6 commits intomainfrom
update-go-tpls

Conversation

@fibonacci1729
Copy link
Copy Markdown
Collaborator

@fibonacci1729 fibonacci1729 commented May 4, 2026

No description provided.

@fibonacci1729
Update Go templates
9f4c92d 
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
adamreese
adamreese approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adamreese adamreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but also a dup of #3438

@fibonacci1729 fibonacci1729 mentioned this pull request May 4, 2026
Closed
@itowlson
Copy link
Copy Markdown
Collaborator

itowlson commented May 4, 2026

Looks like componentize-go won't run on down-level Ubuntu. @adamreese Is it possible to change componentize-go CI to build it on an older Linux, so as to maximise portability?

@adamreese
Copy link
Copy Markdown
Contributor

adamreese commented May 4, 2026

Verified issue locally. Opened an issue bytecodealliance/componentize-go#50

@adamreese
Copy link
Copy Markdown
Contributor

adamreese commented May 4, 2026

A new version of componentize-go should be released by tomorrow. We'll need to update the version in go.mod when that's completed.

adamreese
adamreese reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@adamreese adamreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version of componentize-go is released

Comment thread templates/http-go/content/go.mod Outdated
Comment thread templates/redis-go/content/go.mod Outdated
fibonacci1729 and others added 2 commits May 4, 2026 18:32
@fibonacci1729 @adamreese
Update templates/redis-go/content/go.mod
c5f60b3 
Co-authored-by: Adam Reese <2347529+adamreese@users.noreply.github.com>
@fibonacci1729 @adamreese
Update templates/http-go/content/go.mod
9e73d02 
Co-authored-by: Adam Reese <2347529+adamreese@users.noreply.github.com>
@adamreese
Copy link
Copy Markdown
Contributor

adamreese commented May 5, 2026

@fibonacci1729 Now that we're using Big Go, we need empty main() functions again. https://github.com/spinframework/spin-go-sdk/blob/main/examples/http/main.go#L21

fibonacci1729 and others added 2 commits May 5, 2026 10:21
@fibonacci1729
Include main funcs
e02bd3d 
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@itowlson
Update go.sum and Redis build command
21848c3 
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson
Copy link
Copy Markdown
Collaborator

itowlson commented May 6, 2026

I sent #3493 to hopefully address the templates not building correctly (although I tested with Go 1.26, I dunno if that will affect the go.sum stuff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itowlson itowlson Awaiting requested review from itowlson

1 more reviewer

@adamreese adamreese adamreese approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fibonacci1729 @itowlson @adamreese