fix(containerd): update k3s systemd unit restart to support agent mode#621
Open
vdice wants to merge 1 commit intospinframework:mainfrom
Open
fix(containerd): update k3s systemd unit restart to support agent mode#621vdice wants to merge 1 commit intospinframework:mainfrom
vdice wants to merge 1 commit intospinframework:mainfrom
Conversation
vdice
force-pushed
the
fix/k3s-restart-systemd
branch
from
11da47d to
8463afd
Compare
Signed-off-by: Vaughn Dice <vdice@akamai.com>
vdice
force-pushed
the
fix/k3s-restart-systemd
branch
from
8463afd to
0a84e60
Compare
kate-goldenring
approved these changes
Mar 13, 2026
| out, err := nsenterCmd("systemctl", "restart", "k3s").CombinedOutput() | ||
| // First, collect systemd units to determine which k3s service to restart | ||
| // TODO: It appears the service name itself can be customized, so we may want to consider similar support | ||
| // See https://github.com/k3s-io/k3s/blob/main/install.sh |
Contributor
There was a problem hiding this comment.
Can you create a follow up issue for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates the k3s restart logic when systemd units are used to check if either
k3sork3s-agentis the registered service.#620 has more detail, but essentially most real-world k3s clusters use the latter
k3s-agentservice while quickstart/minimal k3s deployments (egcurl -sfL https://get.k3s.io | sh -usek3s)Note the TODO around allowing specification of the registered service, as it appears the k3s installer script allows customization. This should be a separate follow-up if deemed necessary.
Issue ticket number and link
#620
Checklist before requesting a review