fix(spiffeid): tighten path validation and segment construction#420
Merged
maxlambrecht merged 4 commits intospiffe:mainfrom Mar 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens SPIFFE ID path validation to align SpiffeId.validatePath() with segment-based SPIFFE ID construction, and expands tests to document trust-domain edge cases allowed by the SPIFFE spec.
Changes:
- Require
SpiffeId.validatePath()inputs to start with/and validate segments more explicitly. - Validate segments independently in
SpiffeId.fromSegments(...)(instead of validating as full paths). - Add/adjust unit tests for canonical casing and non-DNS-shaped trust domains (underscore, IPv4, and other edge shapes).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| java-spiffe-core/src/main/java/io/spiffe/spiffeid/SpiffeId.java | Updates path validation and switches segment construction to validate each segment directly. |
| java-spiffe-core/src/test/java/io/spiffe/spiffeid/SpiffeIdTest.java | Adds coverage for validatePath leading-slash rules, canonical casing, equality semantics, and non-DNS trust domains. |
| java-spiffe-core/src/test/java/io/spiffe/spiffeid/TrustDomainTest.java | Adds coverage for non-DNS-shaped trust domains, underscore/IPv4 acceptance, and IPv6 rejection. |
| java-spiffe-core/src/test/java/io/spiffe/svid/jwtsvid/JwtSvidParseInsecureTest.java | Updates SPIFFE ID construction to use segments ("host") instead of a path string ("/host"). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
5024785 to
63c763d
Compare
rturner3
reviewed
Mar 25, 2026
java-spiffe-core/src/main/java/io/spiffe/spiffeid/SpiffeId.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
…mbrecht/java-spiffe into fix/spiffeid-path-segments
rturner3
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SpiffeId.validatePath()inputs to start with/Why
How tested
SpiffeIdTestandTrustDomainTest