Merged
Conversation
f321x
force-pushed
the
bolt12_preparation_1
branch
6 times, most recently
from
4ed0aed to
efa2a14
Compare
…ply_paths. the former also calculates payinfo information for payment scenarios. include payment_relay struct for payment blinded_paths.
Add unittest to test the payment path of get_blinded_paths_to_me
Mock LNWallet._add_peer so direct connection fallbacks don't cause an exception.
This allows restricting blinded paths to channels that have sufficient receive capacity for payment. NOTE: this might have privacy issues, as this can be used to probe channel capacity. Maybe randomize leeway? @f321x: changed to use scid alias in create_blinded_path
Factor out code from `send_onion_message_to` into a separate function `_create_route_to_introduction_point` to make it easier to reason about it and more testable.
Don't include first hop of the path, this is the hop from us to the first node and we don't need a payload for ourselves. Also adds unittest checking this.
f321x
force-pushed
the
bolt12_preparation_1
branch
from
efa2a14 to
4254c9a
Compare
SomberNight
approved these changes
Apr 20, 2026
Comment on lines
+432
to
+433
| # randomize list | ||
| rchans = sorted(my_channels, key=lambda x: random()) |
Member
There was a problem hiding this comment.
minor nit, no need to fix here, just wanted to pitch:
rchans = util.random_shuffled_copy(my_channels)
((1) perhaps easier to read; (2) random.shuffle probably uses a Fisher-Yates shuffle, so takes linear time, while sorting is n*log(n))
Lines 2240 to 2244 in 16c8cb5
Comment on lines
+666
to
+671
| # get next path (round robin) | ||
| dests = req.node_id_or_blinded_paths | ||
| if isinstance(req.node_id_or_blinded_paths, bytes): | ||
| dests = [req.node_id_or_blinded_paths] | ||
| dest = dests[req.current_index] | ||
| req.current_index = (req.current_index + 1) % len(dests) |
Member
There was a problem hiding this comment.
could be a method of Request that returns dest and internally mutates current_index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the bolt12 branch is getting large, so i cherry picked some commits that can already be reviewed and merged into master step by step. these are mostly onion message changes.