Refactor Mux subscription lifecycle with ref counting#1685
Refactor Mux subscription lifecycle with ref counting#1685
Conversation
Introduced `acquireSubscription` helper to manage local subscription caching, reference counting, and race conditions. Refactored `CreatePortal` and `OpenPortal` to use this helper, ensuring subscriptions are shared and only closed when no longer in use. Added `TestMux_CreatePortal_RefCounting` to verify the fix. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This PR addresses potential race conditions and inefficient subscription management in the
Muxcomponent.Changes:
acquireSubscriptionintavern/internal/portals/mux/mux_pubsub.go: Centralizes subscription acquisition logic, including cache checking, provisioning, connection, race handling, and reference counting.CreatePortalintavern/internal/portals/mux/mux_create.go: Now usesacquireSubscriptioninstead of blindly overwriting existing subscriptions. This prevents premature closure if a subscription is already active (e.g. from a race or collision).OpenPortalintavern/internal/portals/mux/mux_open.go: Refactored to useacquireSubscriptionfor consistency and code reuse.TestMux_CreatePortal_RefCountingintavern/internal/portals/mux/mux_test.go: Verifies thatCreatePortalcorrectly initializes reference counts and that teardown respects them (subscription remains active if refs > 0).This ensures that local subscriptions are robustly managed and shared where appropriate.
PR created automatically by Jules for task 13481624774023790476 started by @KCarretto