fix: pass audio sample rate and width to Silero VAD#90
Draft
Conversation
Silero VAD process_audio was called without sample_rate or sample_width, defaulting to 16kHz. With 8kHz audio this silently produced incorrect VAD results instead of surfacing the incompatibility.
Contributor
|
Please can you include a note about testing in the description of your MRs? It helps track and be clear on what has been tested vs. not, and makes it easier to approve without me asking each time. Thanks! In this case, I'm guessing you testing manually with an 8kHz audio and observed the VAD results were correct, after your change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silero VAD process_audio was called without sample_rate or sample_width, defaulting to 16kHz. With 8kHz audio this silently produced incorrect VAD results instead of surfacing the incompatibility.