feat: add optional headers support to WebSocket connection#83
Open
feat: add optional headers support to WebSocket connection#83
Conversation
Introduce an optional `ws_headers` parameter to the `connect` method in `VoiceAgentClient`. This allows users to pass custom headers when establishing the WebSocket connection to the Speechmatics API.
Contributor
|
Looks good. Can you add a comment with the testing you've done? Thanks. |
Introduce two new tests to validate header handling in the STT client. `test_with_headers` checks successful connection using valid headers, while `test_with_corrupted_headers` ensures connection failure with invalid header format.
Member
Author
@LArmstrongDev - new test has been added to include valid and invalid header testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an optional
ws_headersparameter to theconnectmethod inVoiceAgentClientand the underlyingAsyncClient. This allows users to pass custom headers when establishing the WebSocket connection to the Speechmatics API.Test
tests/voice/test_06_stt_config.pytests for valid and invalidws_headerspassed to the connect method.