Fix WorkBench export file extension for selected delimiter#8051
Fix WorkBench export file extension for selected delimiter#8051acwhite211 wants to merge 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes introduce a new Changes
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
emenslin
left a comment
There was a problem hiding this comment.
- Confirm the downloaded file ends in
.csv. - Confirm the exported content is comma-delimited.
- Confirm the downloaded file ends in
.tsv.
Looks good, files seem to be exported correctly.
Iwantexpresso
left a comment
There was a problem hiding this comment.
- Confirm the downloaded file ends in
.csv. - Confirm the exported content is comma-delimited.
- Confirm the downloaded file ends in
.tsv.
-functionality looks great!
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Confirm the downloaded file ends in
.csv. - Confirm the exported content is comma-delimited.
- Confirm the downloaded file ends in
.tsv.
Ran into no errors!
Fixes #8047
Fixes WorkBench data set exports so the downloaded filename extension matches the selected
Export file delimiterpreference.Previously, exports used the configured delimiter for file content, but the filename defaulted to
.tsvunless the caller had already supplied.csv. This caused comma delimited exports to download with the wrong extension.Checklist
self-explanatory (or properly documented)
Testing instructions
Export file delimitertoComma..csv.Export file delimitertoTab..tsv.Summary by CodeRabbit
Bug Fixes
Tests