Conversation
Triggered by 23a7413 on branch refs/heads/issue-7682-2
5 tasks
grantfitzsimmons
approved these changes
Feb 16, 2026
Member
There was a problem hiding this comment.
Strictly UX review:
- Startup Specify on a blank database and use the setup tool to create a Geography database.
I also added new disciplines to an existing database.
- See that the database setup process runs without errors.
- See the the collectionobjectgroupjoin table has it's field text and descriptions properly set based on the geology schema_overrides file
specify7/config/geology/schema_overrides.json
Lines 71 to 81 in 5789550
Triggered by c48c95a on branch refs/heads/issue-7682-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7682
This fix addresses two root causes in schema config override application: first,
update_schema_config.pynow preserves explicitishiddenoverrides fromconfig/<discipline>/schema_overrides.jsonduring migration-time hide/unhide passes, including applying the explicit true/false value when rerun, so fields likecollectionobjectgroupjoin.text1/text2in Geology are no longer accidentally re-hidden; second, theSplocaleitemstrwrite path was changed from effectively insert-only behavior to true upsert behavior keyed by language + FK (itemname/itemdesc/containername/containerdesc), which updates existing caption/description text and removes duplicates instead of leaving stale values likeText1. Finally,run_key_migration_functions.fix_schema_configwas updated to reapply schema defaults/overrides across all disciplines, ensuring existing databases get corrected without manual row edits.Checklist
self-explanatory (or properly documented)
Testing instructions
specify7/config/geology/schema_overrides.json
Lines 71 to 81 in 5789550