fix(workbench): Match Agent records without assuming 'Person'#7700
Open
grantfitzsimmons wants to merge 2 commits intomainfrom
Open
fix(workbench): Match Agent records without assuming 'Person'#7700grantfitzsimmons wants to merge 2 commits intomainfrom
grantfitzsimmons wants to merge 2 commits intomainfrom
Conversation
emenslin
approved these changes
Feb 16, 2026
Collaborator
emenslin
left a comment
emenslin
left a comment
There was a problem hiding this comment.
- Create a WorkBench data set that includes 'Agent' links that match to existing records, where the agent is of any other type (not 'Person')
- Add rows that match to 'Person' agents
- Add rows that do not match to 'Person' agents
- Add rows that create new agents of each type
- Test agent matching via complicated relationships (e.g. collectors, preparators, or other one-to-many links)
- Test agent matching via direct links (e.g. cataloger, agent1, agent2, etc.)
- Verify that matching works as expected!
- Verify that newly created records, when
AgentTypeis not specified, are added as 'Person' agents
Looks good, I didn't run into any issues!
bhumikaguptaa
approved these changes
Feb 16, 2026
Collaborator
bhumikaguptaa
left a comment
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Create a WorkBench data set that includes 'Agent' links that match to existing records, where the agent is of any other type (not 'Person')
- Add rows that match to 'Person' agents
- Add rows that do not match to 'Person' agents
- Add rows that create new agents of each type
- Test agent matching via complicated relationships (e.g. collectors, preparators, or other one-to-many links)
- Test agent matching via direct links (e.g. cataloger, agent1, agent2, etc.)
- Verify that matching works as expected!
- Verify that newly created records, when
AgentTypeis not specified, are added as 'Person' agents
Works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3723
Makes it so that Agent matching can be done for Agents of any type. Previously, the WorkBench would only look for records where
AgentTypewas 'Person' (1) for matching purposes. This remedies that.This PR:
Current Behavior:
Testing instructions
Compare the behavior against the latest tagged release and the branch this is based on.
AgentTypeis not specified, are added as 'Person' agents