fix: removed add button from collectionPreferences of the SpAppResource table #7684
fix: removed add button from collectionPreferences of the SpAppResource table #7684
collectionPreferences of the SpAppResource table #7684Conversation
|
As an aside, I have a comment about a couple minor UI bugs regarding the save button within collection preferences depending on where it's accessed. For example, going through the route of User Tools --> App Resources --> Collection Preferences, the save button begins as grayed out. After making edits but then returning to default state, it reappears as its beginning grayed out state. It makes more sense to have this be a functional close button. Screen.Recording.2026-02-04.at.3.02.58.PM.movGoing straight to User Tools --> Collection Preferences, there is a functional close button as default. This makes sense! However, if I alter the page by selecting and unselecting options and then return to how it was at the beginning, I cannot return to the original state close button. Screen.Recording.2026-02-04.at.3.04.25.PM.mov |
emenslin
left a comment
There was a problem hiding this comment.
- Go to app resources, click on collection preferences, and verify that the add button is absent
Looks good! My only note is that this applies to all app resources not just collection preferences, this seems intentional based on what you said at the beginning of the PR; however, since the testing instructions only mention checking collection preferences I wanted to make note of it here.
Also just so you know I did look at your videos and I was not able to recreate the issue when going through app resources, and I honestly don't recall ever running into it (although I could be wrong) so there might be something else effecting that behavior.
02-09_11.19.mp4
Triggered by 0c26e26 on branch refs/heads/issue-4950
SpAppResource tablecollectionPreferences of the SpAppResource table
|
@emenslin Thank you for your feedback! I revised my solution because it was wrong to disable add for all app resources. Regarding my comment about the save button, your video does in fact show what I discussed. Notice how when you enter the form, the bottom right button is a white/gray "unclickable" save button? I think there should be a change made here to recognize that nothing has actually changed and the button should return to how it was when you entered the form. Does that make sense? |
combs-a
left a comment
There was a problem hiding this comment.
- Go to app resources, click on collection preferences, and verify that the add button is absent
- Verify that other app resources still have add button functionality
It is disabled on Collection Preferences. 👍
Not within in the scope of this PR since this does not cause an error when pressed, but wanted to note: or other things like Default Preferences and User Preferences, the Add button is still present. User Preferences also does not have an Add button if you navigate to it directly through the User Tools menu, so I wanted to note that it was inconsistent. I'll split it off into a separate QoL issue.
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Go to app resources, click on collection preferences, and verify that the add button is absent
- Verify that other app resources still have the add button functionality
Works as expected. The add button is disabled in Collection Preferences.

Fixes #4950
This fix removes the add button from the
collectionPreferencesApp Resource. In the UI, this is noticeable when you navigate to User Tools --> App Resources --> Collection Preferences. At the bottom right of the screen, only a save button appears now as the add button did not serve a necessary purpose.The change comes by hiding the add button for the specific Collection Preferences App Resource (while for other App Resources it will be unaffected) in
Save.tsx:specify7/specifyweb/frontend/js_src/lib/components/Forms/Save.tsx
Line 410 in 0c26e26
Checklist
self-explanatory (or properly documented)
Testing instructions