fix(w3c/headers): show version URLs as readable IRIs - #5378
Draft
marcoscaceres wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the W3C header “version links” rendering so that link text displays a human-readable IRI (decoded when possible), while the link href preserves the percent-encoded URL. This addresses specs whose URLs contain non‑ASCII characters without breaking the actual target URL, and avoids throwing on malformed escape sequences.
Changes:
- Update W3C headers template to decode version URL strings for display text only (thisVersion, latestVersion, edDraftURI, historyURI, prevVersion).
- Add a
safeDecodeURI()helper that falls back to the original string when decoding fails. - Add regression tests covering readable IRI display, malformed escape sequences, and additional version URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/spec/w3c/headers-spec.js | Adds coverage ensuring displayed link text is decoded IRI while href remains encoded, including malformed-escape fallback. |
| src/w3c/templates/headers.js | Uses decoded IRI strings for link text across the version links, keeping existing href values intact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4910
The version links in the header now show the human-readable IRI as link text while the
hrefkeeps the percent-encoded URL, so a spec with non-ASCII characters in its URL reads normally. Applies to all five of the version URLs in that list, not justlatestVersion:thisVersion,edDraftURI,historyURIandprevVersionhad the same problem on adjacent lines. Malformed escape sequences are left as-is rather than throwing.Written with AI: this change was generated by Claude, and the regression test was proven to fail without the fix. Per AI_POLICY.md.