-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Stable network identity from device id #2954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Stable network identity from device id #2954
Conversation
Network identity now derives from device ID, ensuring stability and fixing pairing issues. Co-authored-by: ijamespine <ijamespine@me.com>
|
Cursor Agent can help with this pull request. Just |
PR SummaryBreaking: Network identity now derives from
Written by Cursor Bugbot for commit b6161f9. Configure here. |
|
@cursor remove the changelog we use git tags |
|
Removed Learn more about Cursor Agents |
Co-authored-by: ijamespine <ijamespine@me.com>
core/src/service/network/core/mod.rs
Outdated
|
|
||
| // Create Iroh data directory | ||
| let iroh_data_dir = data_dir_path.join("iroh"); | ||
| std::fs::create_dir_all(&iroh_data_dir).map_err(|e| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Iroh data directory is created here but then the path is recomputed in start() at line 225. Consider storing iroh_data_dir directly instead of recomputing it from data_dir.
Co-authored-by: ijamespine <ijamespine@me.com>
Co-authored-by: tembo[bot] <208362400+tembo[bot]@users.noreply.github.com>
This change introduces logic to save and load a cache of known node addresses for the Iroh networking stack. This improves reconnection reliability by pre-seeding the Iroh endpoint with previously known nodes, including their relay URLs if available. The documentation has also been updated to reflect the new storage location for this cache. Co-authored-by: ijamespine <ijamespine@me.com>
…o tembo/refactor-network-identity-generation
…entity-generation Refactor Network Identity Generation
This PR addresses critical network identity issues by deriving the Iroh
node_iddeterministically from the stabledevice_id(fromdevice.json) instead of thedevice_key(from keyring). It also configures Iroh state persistence.This change fixes:
Breaking Change: All devices must re-pair after updating to this version. This is acceptable for prerelease.
Closes #XXXX