-
-
Notifications
You must be signed in to change notification settings - Fork 64
Update configuration instructions to center JSON format #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| | `rate.ip.count` | 500 | number | Allowed number of requests per IP within window | | ||
| | `rate.ip.window` | 5 | number | IP rate limit window, in seconds | | ||
| | `rate.global.count` | 250 | number | Allowed number of requests globally within window | | ||
| | `rate.global.window` | 5 | number | Global rate limit window, in seconds | | ||
| | `rate.error.count` | 10 | number | Number of allowed errors per user within window | | ||
| | `rate.error.window` | 5 | number | User error rate limit window, in seconds | | ||
| | `rate.routes.guild.count` | 5 | number | Allowed number of /guild\* requests per user within window | | ||
| | `rate.routes.guild.window` | 5 | number | User /guild\* rate limit window, in seconds | | ||
| | `rate.routes.webhook.count` | 10 | number | Allowed number of /webhooks\* requests per user within window | | ||
| | `rate.routes.webhook.window` | 5 | number | User /webhooks\* rate limit window, in seconds | | ||
| | `rate.routes.channel.count` | 10 | number | Allowed number of /channel\* requests per user within window | | ||
| | `rate.routes.channel.window` | 5 | number | User /channel\* rate limit window, in seconds | | ||
| | `rate.routes.auth.login.count` | 5 | number | Allowed number of IP /login requests within window | | ||
| | `rate.routes.auth.login.window` | 60 | number | IP /login rate limit window, in seconds | | ||
| | `rate.routes.auth.register.count` | 2 | number | Allowed number of IP /register requests within window | | ||
| | `rate.routes.auth.register.window` | 43200 | number | IP /register rate limit window, in seconds | | ||
| | `absoluteRate.register.limit` | 25 | number | Absolute number of registrations instance-wide per window | | ||
| | `absoluteRate.register.window` | 3600000 | number | Global /register rate limit window, in milliseconds | | ||
| | `absoluteRate.register.enabled` | true | boolean | Whether absolute register rate limits are enabled | | ||
| | `absoluteRate.sendMessage.limit` | 200 | number | Absolute number of messages instance-wide per window | | ||
| | `absoluteRate.sendMessage.window` | 60000 | number | Global sendMessage window, in milliseconds | | ||
| | `absoluteRate.sendMessage.enabled` | true | boolean | Whether absolute message sending rate limits are enabled | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note for future sake, not a blocker: I would probably rework this into a couple more compact sections (ie generalising the definition of "window" and "limit" for most of them, and explaining what absoluteRate is)
| "general": { | ||
| "instanceDescription": "I'm in space!", | ||
| "instanceName": "A Spacebar Instance", | ||
| "serverName": "spacebar.example.net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just be example.net fwiw, if you wanted to do it that way :P
Do not mention the DB
configtable. Instead explain how the JSON configuration file looks and how to tell spacebar where to find it