Upgrade Core and Blaze#925
Conversation
There was a problem hiding this comment.
No issues found across 368 files
Note: This PR contains a large number of files. cubic only reviews up to 200 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
Re-trigger cubic
🤖 Augment PR SummarySummary: This PR upgrades the vendored Changes:
Notes: The bulk of the diff is dependency/vendor code updates; the main integration risk is build-option/API mismatches between jsonbinpack’s build glue and the upgraded vendored projects. 🤖 Was this summary useful? React with 👍 or 👎 |
| ? evaluateInstructionTracked | ||
| : evaluateInstructionFast; | ||
| evaluator.callbackMode = false; | ||
| const result = evaluateInstruction(instruction, instance, depth, template, evaluator); |
There was a problem hiding this comment.
vendor/blaze/ports/javascript/index.mjs:703-713 — evaluateInstructionWithoutCallback restores evaluateInstruction/evaluator.callbackMode only on the normal return path; if evaluateInstruction(...) throws, the dispatcher/callback mode can remain mutated for subsequent evaluations. Consider ensuring the restoration happens on exception paths as well so a single failure can’t corrupt evaluator state.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| option(BLAZE_ALTERSCHEMA "Build the Blaze alterschema rule library" ON) | ||
| option(BLAZE_CODEGEN "Build the Blaze codegen library" ON) | ||
| option(BLAZE_DOCUMENTATION "Build the Blaze documentation generator library" ON) | ||
| option(BLAZE_CANONICALIZER "Build the Blaze canonicalizer library" ON) |
There was a problem hiding this comment.
vendor/blaze/CMakeLists.txt:15 — this introduces BLAZE_CANONICALIZER in place of the old BLAZE_DOCUMENTATION option, but jsonbinpack’s cmake/FindBlaze.cmake still sets BLAZE_DOCUMENTATION OFF before add_subdirectory(vendor/blaze). That means the canonicalizer component will stay enabled unexpectedly, potentially changing what gets built/linked in this repo.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti jv@jviotti.com