refactor: Wilps contribution 2026-07-09#155
Open
gynt wants to merge 1 commit into
Open
Conversation
TheRedDaemon
requested changes
Jul 13, 2026
| uint aiShouldBuildPitchrig(PlayerID param_1); | ||
|
|
||
| BOOLEnum shouldNotBeBuildingHovel(PlayerID playerID, CommandBuildingType param_2); | ||
| BOOLEnum shouldNotBeBuildingHovel(PlayerID playerID, CommandBuildingTypeInt param_2); |
Contributor
There was a problem hiding this comment.
Before I try to look at 300 files: Is this intended, that the Enums are replaced here again?
Contributor
Author
There was a problem hiding this comment.
No, it isn't. I guess this was done on and old SARIF export before switched the enum stuff. Luckily I use python scripts to do that enum change so I can run it again and improve this PR.
Contributor
There was a problem hiding this comment.
I do not know when you did the last sarif export, but after the renaming and this one, you should do another one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.