fix: ensure enclosing ranges contain occurrences - #469
Open
mskry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Reproduction
Use the existing enclosing-range fixture:
Before the fix, the occurrence covered
test, while the enclosing range covered only the initializer:The source-file occurrence had the same problem when the file started with comments: its occurrence was at
[0,0,0], but its enclosing range started after the leading comments.The new snapshot assertion fails when either malformed range is generated.
Verification
enclosing_rangecontains its occurrence.npm run test: 31/31 passed.npm run build.npm run prettier-check.npm run eslint.