fix: use configureEach instead of all for JavaCompile tasks#852
Open
tinder-ryantrontz wants to merge 1 commit intosourcegraph:mainfrom
Open
Conversation
The eager .all {} API forces realization of lazily-registered
JavaCompile tasks during afterEvaluate. When a project defines custom
source sets (e.g. intTest) with a Java toolchain, Gradle finalizes
the javaCompiler property during task realization — before
JavaBasePlugin.createCompileJavaTask finishes setting its convention.
This causes: 'property javaCompiler is final and cannot be changed'.
Replacing .all {} with .configureEach {} defers the configuration
action until Gradle has fully initialized each task.
Amp-Thread-ID: https://ampcode.com/threads/T-019cbfff-d981-727b-9564-00e5705dbcec
Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scip-java indexcrashes on Gradle 8.12.1 projects that define custom source sets (e.g.intTest) with a Java toolchain:Root Cause
SemanticdbGradlePluginuses the eager.withType(JavaCompile).all {}API insideafterEvaluate. This forces immediate realization of lazily-registeredJavaCompiletasks. During realization, the plugin readsjavaCompilervia.getOrNull(), which triggers Gradle'sfinalizeValueOnRead— locking the property beforeJavaBasePlugincan set itsconvention().Fix
Replace
.all {}with.configureEach {}(line 107 ofSemanticdbGradlePlugin.scala). This defers the configuration action until Gradle has fully initialized each task.Note: the Scala plugin path on line 222 already uses
.configureEach {}correctly.Verification
lazy-sourceset-with-toolchainreproduces the scenario (customintTestsource set + toolchain)Gradle_8_BuildToolSuitepasses (16/16, 1 skipped for JDK version)BUILD SUCCESSFUL,index.scipgenerated