fix: correct patch generation when discarding partial changes of staged new files#2189
Closed
gadfly3173 wants to merge 1 commit intosourcegit-scm:developfrom
Closed
fix: correct patch generation when discarding partial changes of staged new files#2189gadfly3173 wants to merge 1 commit intosourcegit-scm:developfrom
gadfly3173 wants to merge 1 commit intosourcegit-scm:developfrom
Conversation
…ed new files When a new file was already staged and the user tried to discard selected lines from the unstaged changes list, the generated patch was malformed due to incorrect index header format, wrong hunk line numbers, and unconditional "No newline at end of file" marker.
love-linger
added a commit
that referenced
this pull request
Mar 13, 2026
…rtically (#2189) Signed-off-by: leo <longshuang@msn.cn>
Collaborator
|
I've pushed my fix for this bug - 1ca86ad |
Contributor
Author
|
index 格式、tail null 等问题可以考虑也修一下 |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new file was already staged and the user tried to discard selected lines from the unstaged changes list, the generated patch was malformed due to incorrect index header format, wrong hunk line numbers, and unconditional "No newline at end of file" marker.