feat(billing): add billing endpoints#121
Open
Sourav-kashyap wants to merge 5 commits into
Open
Conversation
Sourav-kashyap
force-pushed
the
GH-120
branch
3 times, most recently
from
0d1d5b3 to
2fe29d0
Compare
yeshamavani
requested changes
May 20, 2026
Comment on lines
+76
to
+85
| process.env.FEATURE_DB_HOST = 'localhost'; | ||
| process.env.FEATURE_DB_PORT = '5432'; | ||
| process.env.FEATURE_DB_USER = 'test'; | ||
| process.env.FEATURE_DB_PASSWORD = 'test'; | ||
| process.env.FEATURE_DB_DATABASE = 'test'; | ||
| process.env.FEATURE_DB_SCHEMA = 'public'; | ||
| // Billing config | ||
| process.env.SITE = 'test'; | ||
| process.env.API_KEY = 'test'; | ||
| process.env.STRIPE_SECRET = 'test'; |
Collaborator
There was a problem hiding this comment.
why a database setup, cant we use memory store here ?
| @post(`${BASE}/customers`, { | ||
| summary: 'Create a new customer', | ||
| responses: { | ||
| '200': { |
Comment on lines
+70
to
+86
| schema: { | ||
| type: 'object', | ||
| required: ['firstName', 'lastName', 'email'], | ||
| properties: { | ||
| firstName: {type: 'string', example: 'John'}, | ||
| lastName: {type: 'string', example: 'Doe'}, | ||
| email: {type: 'string', example: 'john.doe@example.com'}, | ||
| company: {type: 'string', example: 'Acme Inc.'}, | ||
| phone: {type: 'string', example: '+1234567890'}, | ||
| billingAddress: { | ||
| type: 'object', | ||
| properties: { | ||
| line1: {type: 'string'}, | ||
| city: {type: 'string'}, | ||
| state: {type: 'string'}, | ||
| zip: {type: 'string'}, | ||
| country: {type: 'string', example: 'US'}, |
Comment on lines
+140
to
+162
| 'application/json': { | ||
| schema: { | ||
| type: 'object', | ||
| properties: { | ||
| firstName: {type: 'string'}, | ||
| lastName: {type: 'string'}, | ||
| email: {type: 'string'}, | ||
| company: {type: 'string'}, | ||
| phone: {type: 'string'}, | ||
| billingAddress: { | ||
| type: 'object', | ||
| properties: { | ||
| line1: {type: 'string'}, | ||
| city: {type: 'string'}, | ||
| state: {type: 'string'}, | ||
| zip: {type: 'string'}, | ||
| country: {type: 'string'}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, |
Comment on lines
+113
to
+119
| this.application.bind(StripeBindings.config).to({ | ||
| secretKey: process.env.STRIPE_SECRET ?? '', | ||
| }); | ||
| this.application | ||
| .bind(BillingComponentBindings.SDKProvider) | ||
| .toProvider(StripeServiceProvider); | ||
|
|
Collaborator
There was a problem hiding this comment.
this will be in sandbox
| // Mount authorization component for default sequence | ||
| this.application.bind(AuthorizationBindings.CONFIG).to({ | ||
| allowAlwaysPaths: ['/explorer'], | ||
| allowAlwaysPaths: ['/explorer', '/billing', '/webhooks'], |
Collaborator
There was a problem hiding this comment.
there was a webhook component right ?
Comment on lines
+26
to
+30
| SITE= | ||
| API_KEY= | ||
| STRIPE_SECRET= | ||
| CHARGEBEE_ITEM_FAMILY_ID= | ||
| BILLING_PROVIDER= |
Collaborator
There was a problem hiding this comment.
no all this will b ein sandbox
Tyagi-Sunny
reviewed
May 21, 2026
| }, | ||
| }) | ||
| async createCustomer( | ||
| @requestBody({ |
Contributor
There was a problem hiding this comment.
does this create the customer on stripe? if yes, then we alreayd has the apis to create the customer. what is the difference between them
Tyagi-Sunny
reviewed
May 21, 2026
| }, | ||
| }) | ||
| async getCustomer( | ||
| @param.path.string('customerId') customerId: string, |
Contributor
There was a problem hiding this comment.
these endpoints already exist exist , review pls
Tyagi-Sunny
reviewed
May 21, 2026
| }, | ||
| }) | ||
| paymentDto: BillingPaymentSourceBody, | ||
| ): Promise<TPaymentSource> { |
Contributor
There was a problem hiding this comment.
we already have the api , then why need to create new
Tyagi-Sunny
reviewed
May 21, 2026
| }, | ||
| }, | ||
| }, | ||
| }, |
Contributor
There was a problem hiding this comment.
keep them seprate , for product , price, keep them separate
Tyagi-Sunny
reviewed
May 21, 2026
| * interceptor to BILLING_WEBHOOK_VERIFIER in application.ts. | ||
| */ | ||
| export class BillingWebhookController { | ||
| constructor( |
Contributor
There was a problem hiding this comment.
we already had a controller for ir
SonarQube reviewer guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds three new billing endpoints to retrieve detailed payment and invoice information, along with TypeScript type improvements for webhook handling. The new endpoints provide essential functionality for invoice management and payment tracking in SaaS subscription workflows.
Type of change
Checklist: