Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
WalkthroughBump Next.js to 16 and related deps (React, Sentry, ESLint tooling); remove some Sentry options; switch page data fetch to direct Prisma query and force dynamic rendering; simplify org data error handling; rename middleware → proxy; migrate ESLint config to module and adjust ignores/overrides. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/web/src/app/page.tsx (1)
4-4: Prefer reusinggetOrgFromDomainto avoid duplicated org lookup logic.This page now duplicates query logic already present in
packages/web/src/data/org.ts. Centralizing on one helper reduces drift risk.♻️ Proposed refactor
-import { prisma } from "@/prisma"; +import { getOrgFromDomain } from "@/data/org"; @@ - const org = await prisma.org.findUnique({ - where: { - domain: SINGLE_TENANT_ORG_DOMAIN - } - }); + const org = await getOrgFromDomain(SINGLE_TENANT_ORG_DOMAIN);Also applies to: 14-18
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/web/src/app/page.tsx` at line 4, The page is duplicating org lookup logic; replace the direct Prisma query in page.tsx with a call to the existing helper getOrgFromDomain (from packages/web/src/data/org.ts) to centralize lookup logic, remove the duplicated Prisma query, and add the appropriate import for getOrgFromDomain; ensure any downstream usage (variables returned from the original query) is adapted to the shape returned by getOrgFromDomain so behavior remains unchanged.packages/web/package.json (1)
166-168: Aligneslint-plugin-react-hookswith React 19.2 guidance by upgrading to v6+.React is upgraded to 19.2.4, and React 19.2 documentation explicitly recommends
eslint-plugin-react-hooksv6+. Your project currently uses v5.2.0 with ESLint 8. While v5.2.0 still functions, v6+ is the recommended path forward for React 19.2 tooling alignment (v6+ is designed for ESLint 9 and flat config). Upgrading to v6+ will ensure you stay aligned with React's current best practices.🔧 Proposed fix
"devDependencies": { - "eslint-plugin-react-hooks": "^5.2.0", + "eslint-plugin-react-hooks": "^6.0.0", }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/web/package.json` around lines 166 - 168, Update the dependency "eslint-plugin-react-hooks" from v5.2.0 to a v6+ release (e.g. ^6.0.0) in package.json and reinstall dependencies (npm/yarn/pnpm) so the project uses the plugin aligned with React 19.2.4; after upgrading, run the linter and fix any rule-name or config warnings (adjust ESLint config if needed for plugin v6 compatibility) and ensure CI lint step still passes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/web/package.json`:
- Around line 166-168: Update the dependency "eslint-plugin-react-hooks" from
v5.2.0 to a v6+ release (e.g. ^6.0.0) in package.json and reinstall dependencies
(npm/yarn/pnpm) so the project uses the plugin aligned with React 19.2.4; after
upgrading, run the linter and fix any rule-name or config warnings (adjust
ESLint config if needed for plugin v6 compatibility) and ensure CI lint step
still passes.
In `@packages/web/src/app/page.tsx`:
- Line 4: The page is duplicating org lookup logic; replace the direct Prisma
query in page.tsx with a call to the existing helper getOrgFromDomain (from
packages/web/src/data/org.ts) to centralize lookup logic, remove the duplicated
Prisma query, and add the appropriate import for getOrgFromDomain; ensure any
downstream usage (variables returned from the original query) is adapted to the
shape returned by getOrgFromDomain so behavior remains unchanged.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (7)
CHANGELOG.mdpackages/web/next.config.mjspackages/web/package.jsonpackages/web/src/app/page.tsxpackages/web/src/data/org.tspackages/web/src/proxy.tspackages/web/tsconfig.json
💤 Files with no reviewable changes (1)
- packages/web/next.config.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit