Mcp undefined filename bug #718
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…local repos For local repositories, the webUrl field is undefined since there's no web hosting URL. This fix makes both search_code and list_repos tools fallback to the fileName.text and repoCloneUrl respectively when webUrl is not available.
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MCP results returning undefined filenames for local repositories by adding fallbacks for
webUrl.For local repositories, the
webUrlfield is inherently undefined. The MCPsearch_codeandlist_repostools were directly usingfile.webUrlandrepo.webUrlrespectively, leading to "undefined" being displayed. This PR introduces fallbacks tofile.fileName.textfor search results andrepo.repoCloneUrlfor repo listings whenwebUrlis not available.Fixes #717
Linear Issue: SOU-193