Skip to content

feat: surface partial sign-ups when pairing session closes unfulfilled#555

Merged
kylehoehns merged 1 commit intomainfrom
feat/pairing-unfulfilled-signups
Apr 15, 2026
Merged

feat: surface partial sign-ups when pairing session closes unfulfilled#555
kylehoehns merged 1 commit intomainfrom
feat/pairing-unfulfilled-signups

Conversation

@kylehoehns
Copy link
Copy Markdown
Contributor

Summary

  • When a pairing session closes without filling all slots, the reply now lists any teammates who did sign up, grouped by slot, so recruiters can follow up directly.
  • If nobody signed up at all, falls back to a "No teammates signed up." message.
  • Extracted a small finalize helper to remove the duplicated reply + remove + releaseLock sequence across both close branches.

Test plan

  • pnpm verify passes (207 tests)
  • New test covers partial sign-ups across multiple slots (including a slot with no interest)
  • Existing unfulfilled + confirmed close tests still pass

When a pairing session times out without filling all slots, include any
teammates who did sign up (grouped by slot) so recruiters can reach out
directly. Also extracts a small finalize helper to remove duplicated
reply + remove + releaseLock across both close branches.
@kylehoehns kylehoehns merged commit bf63bdb into main Apr 15, 2026
1 check passed
@kylehoehns kylehoehns deleted the feat/pairing-unfulfilled-signups branch April 15, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant