feat: expand review queue instead of expiring pending reviewers#551
Open
kylehoehns wants to merge 1 commit intomainfrom
Open
feat: expand review queue instead of expiring pending reviewers#551kylehoehns wants to merge 1 commit intomainfrom
kylehoehns wants to merge 1 commit intomainfrom
Conversation
Replace the 30-minute per-reviewer expiration model with a review-level expansion model. Instead of closing a pending reviewer's DM after 30 minutes and replacing them, the cron now adds a new batch of reviewers alongside existing pending reviewers at each cycle. - Remove expiresAt from PendingReviewer/PendingPairingTeammate - Add nextExpandAt to ActiveReview and PairingSession (review-level timer) - Replace expireRequest with expandRequest (adds NUMBER_OF_INITIAL_REVIEWERS per cycle) - Replace expirePairingRequests teammate-level expiry with expandTeammates - Single DB write per expand cycle (was N writes, one per reviewer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expiresAtremoved fromPendingReviewer/PendingPairingTeammate; replaced withnextExpandAtonActiveReviewandPairingSessionNUMBER_OF_INITIAL_REVIEWERSpeople per cycle (same batch size as initial requests), reducing DB writes from N per cycle to 1Test plan
pnpm verify)