Source Academy Game Modes Integration#3729
Merged
RichDom2185 merged 48 commits intosource-academy:masterfrom Apr 5, 2026
Merged
Source Academy Game Modes Integration#3729RichDom2185 merged 48 commits intosource-academy:masterfrom
RichDom2185 merged 48 commits intosource-academy:masterfrom
Conversation
…7-source/frontend into ModeIntegration1.1 bug fixing
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the game's navigation flow by removing the 'Menu' and 'Move' modes, making 'Explore' the primary interaction phase. It introduces a new tooltip system and dynamic cursor changes based on object types, such as doors or chat triggers. While these changes streamline the UI, several issues were identified: a critical regression where automatic game saving was removed during location transitions, a potential runtime crash when hovering over bounding boxes, and the inclusion of debug console logs. Additionally, there are architectural concerns regarding the direct instantiation of game modes and the verbosity of the new action parsing logic.
RichDom2185
reviewed
Apr 5, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
RichDom2185
requested changes
Apr 5, 2026
RichDom2185
requested changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the gameplay of SA game. Now, Talk mode and Move mode are integrated into Explore mode, and Menu mode is gone. The storywriters can now add "change_location_to(locationId)" action under any objects, and add a optional config "back : locationId" in the location configs to realize the Move mode function in the Explore mode. They can also add "show_topics()" action under any object to realize the Talk mode function in Explore mode. Back button in the Explore mode is now changed to a button with the text "turn around and leave", which will lead the players back to the location indicated in the config "back" once clicked. Now the game is by default in Explore mode instead of Menu mode.
Besides, the code for the Menu mode and Move mode are all deleted. The talk mode code are still kept for realizing the show_topics action, but I feel we can delete part of the Talk mode code.
Also, tooltip object is added to realize the display of the next location name while players put their cursors on the door.
And there are two new icons now put at public/assets to indicate the new move and talk interactions while players put their cursors on the objects.
Here is a video for the new gameplay : https://drive.google.com/file/d/1fFHH3UFplifReBeJp6HlbN1GcdwISjmo/view?usp=sharing
Type of change
How to test
https://drive.google.com/file/d/1FqTX61Tvp2fv4RZHyiGdTBrrL-dwfwHi/view?usp=drive_link
here is a modified chapter file that can be used to test the new game play.
Checklist