Skip to content

Breakpoint frontend#3702

Merged
martin-henz merged 15 commits intomasterfrom
breakpoint_frontend
Apr 3, 2026
Merged

Breakpoint frontend#3702
martin-henz merged 15 commits intomasterfrom
breakpoint_frontend

Conversation

@Raaghulk04
Copy link
Copy Markdown
Contributor

@Raaghulk04 Raaghulk04 commented Mar 28, 2026

Description

This PR depends on the js-slang PR [https://github.com/source-academy/js-slang/pull/1926]. The frontend build will fail until the js-slang changes are merged and published to npm, and package.json is updated to the new version."
This PR allows users to access the step with the next/previous breakpoint in the stepper

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces breakpoint navigation to the substitution visualizer, allowing users to jump between debugger statements via updated UI buttons and hotkeys. The implementation includes new logic to scan content markers for debugger statements and adds a renderer for them. Feedback focuses on improving maintainability by removing commented-out code, refactoring duplicated SCSS styles into reusable mixins or placeholders, and replacing hardcoded color values with SASS variables.

@martin-henz martin-henz self-requested a review April 2, 2026 09:15
Copy link
Copy Markdown
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the issues pointed out by gemini-bot.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 2, 2026

Pull Request Test Coverage Report for Build 23936888671

Details

  • 2 of 16 (12.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 41.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sideContent/content/SideContentSubstVisualizer.tsx 2 16 12.5%
Totals Coverage Status
Change from base Build 23890044554: -0.04%
Covered Lines: 5802
Relevant Lines: 12907

💛 - Coveralls

Copy link
Copy Markdown
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@martin-henz martin-henz merged commit 1e9b443 into master Apr 3, 2026
10 checks passed
@martin-henz martin-henz deleted the breakpoint_frontend branch April 3, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants