Conversation
j8xixo12
left a comment
j8xixo12
left a comment
There was a problem hiding this comment.
Thanks @Gene0315 for the great work!
I left some comment in changed files and the following is the checking list before merging this PR:
- Fix all Github Action error
- Simplify the redundant code in this PR
- Clean up unrelated binary files
| :return: FigureCanvas | ||
| """ | ||
| x = self.st.svr.coord[::2] | ||
| pt_mid = np.linspace(2,len(self.st.svr.coord) - 3,num=((len(self.st.svr.coord) - 3) // 2),dtype=int) |
There was a problem hiding this comment.
This code appears many times, would you like to optimize it ?
There was a problem hiding this comment.
Yes, I think I can do it.
There was a problem hiding this comment.
Please remove this binary file, we should not include unrelated file in a PR.
There was a problem hiding this comment.
ok, I will remove them.
|
And when cleaning up the blob files, please remove them and squash. I do not want any blob files appearing in git history. |
yungyuc
added
enhancement
ok, I won't do it again. |
3 participants
Following the issue #338
The PR hides the points on boundary.
Features: The plotting hides the unreasonable points on the boundary.
Strength: It makes the figure look nicer without changing the solution data.
Weakness: It is better to calculate the correct values on the boundary and show them on the boundary.