polish(auth): design-system text styles + insecure-connection warning#337
Merged
Conversation
…max-width Two design-system tidies on the home screen: - The URL error banner built its text style from a bare TextStyle(color:); base it on textTheme.bodyMedium like its ConnectNotice sibling so the banner inherits the themed type instead of the ambient default. - Extract the magic BoxConstraints(maxWidth: 400) into a named _maxContentWidth const, matching the existing _logoSize. No behavioral change. First (clear-cut) PR of the auth polish sweep; subjective layout/colour items to follow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per design review: - The insecure-connection screen is a warning, not an error — it doesn't prevent connecting (there's a "Connect anyway"). Recolor the warning icon from colorScheme.error to colorScheme.warning (SymbolicColors). - Give every free-standing Text an explicit textTheme style, chosen to match its role and current appearance: the insecure-warning body, the consent notice body, and the auth-callback error message all become bodyMedium. (ListTile/AppBar titles already render through the brand textTheme via their component themes, so they're left as-is.) No layout changes. flutter analyze clean; 276 auth tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
WilliamKarolDiCioccio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth-module design-system polish (clear-cut + design-reviewed items). Layout/spacing and new features are out of scope — to follow later.
The module was already adopted in the integration phase: the design-system scanner reports zero hard-rule hits. This PR covers the remaining compliance gaps:
home_screen.dart
TextStyle(color:)→ nowtextTheme.bodyMedium?.copyWith(color:), matching itsConnectNoticesibling.BoxConstraints(maxWidth: 400)magic number → named_maxContentWidthconst (alongside_logoSize).colorScheme.error→colorScheme.warning(SymbolicColors).textTheme.bodyMedium.auth_callback_screen.dart
textTheme.bodyMedium.Every free-standing
Textnow carries an explicit SoliplextextThemestyle chosen to match its role;ListTile/AppBartitles already render through the brandtextThemevia their component themes and are left as-is.No behavioral or layout change.
flutter analyzeclean; 276 auth tests pass.